-
-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TST (string dtype): remove usage of arrow_string_storage fixture #59368
Merged
mroeschke
merged 3 commits into
pandas-dev:main
from
jorisvandenbossche:string-dtype-tests-fixtures-arrow_string_storage
Jul 31, 2024
Merged
TST (string dtype): remove usage of arrow_string_storage fixture #59368
mroeschke
merged 3 commits into
pandas-dev:main
from
jorisvandenbossche:string-dtype-tests-fixtures-arrow_string_storage
Jul 31, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorisvandenbossche
added
Testing
pandas testing functions or related to the test suite
Strings
String extension data type and string data
labels
Jul 31, 2024
mroeschke
approved these changes
Jul 31, 2024
…fixtures-arrow_string_storage
Thanks @jorisvandenbossche |
jorisvandenbossche
deleted the
string-dtype-tests-fixtures-arrow_string_storage
branch
July 31, 2024 18:28
41 tasks
WillAyd
pushed a commit
to WillAyd/pandas
that referenced
this pull request
Aug 14, 2024
…das-dev#59368) * TST (string dtype): remove usage of arrow_string_storage fixture * fixup
WillAyd
pushed a commit
to WillAyd/pandas
that referenced
this pull request
Aug 15, 2024
…das-dev#59368) * TST (string dtype): remove usage of arrow_string_storage fixture * fixup
WillAyd
pushed a commit
to WillAyd/pandas
that referenced
this pull request
Aug 15, 2024
…das-dev#59368) * TST (string dtype): remove usage of arrow_string_storage fixture * fixup
WillAyd
pushed a commit
to WillAyd/pandas
that referenced
this pull request
Aug 15, 2024
…das-dev#59368) * TST (string dtype): remove usage of arrow_string_storage fixture * fixup
WillAyd
pushed a commit
to WillAyd/pandas
that referenced
this pull request
Aug 21, 2024
…das-dev#59368) * TST (string dtype): remove usage of arrow_string_storage fixture * fixup
WillAyd
pushed a commit
to WillAyd/pandas
that referenced
this pull request
Aug 22, 2024
…das-dev#59368) * TST (string dtype): remove usage of arrow_string_storage fixture * fixup
WillAyd
pushed a commit
to WillAyd/pandas
that referenced
this pull request
Aug 22, 2024
…das-dev#59368) * TST (string dtype): remove usage of arrow_string_storage fixture * fixup
WillAyd
pushed a commit
to WillAyd/pandas
that referenced
this pull request
Aug 27, 2024
…das-dev#59368) * TST (string dtype): remove usage of arrow_string_storage fixture * fixup
WillAyd
pushed a commit
to WillAyd/pandas
that referenced
this pull request
Sep 20, 2024
…das-dev#59368) * TST (string dtype): remove usage of arrow_string_storage fixture * fixup
jorisvandenbossche
added a commit
to WillAyd/pandas
that referenced
this pull request
Oct 2, 2024
…das-dev#59368) * TST (string dtype): remove usage of arrow_string_storage fixture * fixup
jorisvandenbossche
added a commit
to WillAyd/pandas
that referenced
this pull request
Oct 2, 2024
…das-dev#59368) * TST (string dtype): remove usage of arrow_string_storage fixture * fixup
jorisvandenbossche
added a commit
to WillAyd/pandas
that referenced
this pull request
Oct 3, 2024
…das-dev#59368) * TST (string dtype): remove usage of arrow_string_storage fixture * fixup
jorisvandenbossche
added a commit
to WillAyd/pandas
that referenced
this pull request
Oct 7, 2024
…das-dev#59368) * TST (string dtype): remove usage of arrow_string_storage fixture * fixup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backported
Strings
String extension data type and string data
Testing
pandas testing functions or related to the test suite
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes one other use of
"pyarrow_numpy"
in the tests.This essentially reverts #54535, because we now again can check `.storage == "pyarrow" for both dtype variants that use pyarrow as storage.
xref #54792